Bunch of fixes #354

Manos Pitsidianakis · 2024-02-13T14:15:50+02:00

Manos Pitsidianakis commented

2024-02-13 14:15:50 +02:00

Summary of the PR

Requirements

Before submitting your PR, please make sure you have addressed the following requirements:

All commits in this PR are signed (with git commit -s), and the commit has a message describing the motivation behind the change, if appropriate.
All added/changed public-facing functionality, especially configuration options, are documented in the manual pages.
Any newly added unsafe code is properly documented.
Each commit has been formatted with rustfmt. Run make fmt in the project root.
Each commit has been linted with clippy. Run make lint in the project root.
Each commit does not break any test. Run make test in the project root. If you have cargo-nextest installed, you can run cargo nextest run --all --no-fail-fast --all-features --future-incompat-report instead.

### Summary of the PR  ### Requirements Before submitting your PR, please make sure you have addressed the following requirements: * [ ] All commits in this PR are signed (with `git commit -s`), and the commit has a message describing the motivation behind the change, if appropriate. * [ ] All added/changed public-facing functionality, especially configuration options, are documented in the manual pages. * [ ] Any newly added `unsafe` code is properly documented. * [ ] Each commit has been formatted with `rustfmt`. Run `make fmt` in the project root. * [ ] Each commit has been linted with `clippy`. Run `make lint` in the project root. * [ ] Each commit does not break any test. Run `make test` in the project root. If you have `cargo-nextest` installed, you can run `cargo nextest run --all --no-fail-fast --all-features --future-incompat-report` instead.

Manos Pitsidianakis added 6 commits 2024-02-13 14:15:51 +02:00

8de8addd11

melib/datetime: add cfg for musl builds

Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>

70fc2b455c

Update nix dependency to 0.27

Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>

1048ce6824

melib/utils: add hostname() utility function

Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>

c332c2f5ff

Fix new clippy lints (mostly clippy::blocks_in_conditions)

Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>

873a67d0fb

Replace erroneous use of set_err_kind with set_kind

set_err_kind() is a method of the IntoError trait, not an Error method;
it is meant to be used for any error type that can be converted into
Error. Since melib::Error implements Into<melib::Error> tautologically,
this was not a compilation error. Nevertheless, the correct thing to do
is use the type method directly to set ErrorKind.

Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>

Run cargo lints / Lint on ${{ matrix.build }} (linux-amd64, ubuntu-latest, stable, x86_64-unknown-linux-gnu) (pull_request) Successful in 8m19s Details

Cargo manifest lints / Lint Cargo manifests on ${{ matrix.build }} (linux-amd64, ubuntu-latest, stable, x86_64-unknown-linux-gnu) (pull_request) Successful in 13m29s Details

Run Tests / Test on ${{ matrix.build }} (linux-amd64, ubuntu-latest, stable, x86_64-unknown-linux-gnu) (pull_request) Successful in 15m1s Details

417b24cd84

meli: print invalid command on error

Instead of printing just "invalid command", print the command as well.

Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>

Manos Pitsidianakis merged commit 417b24cd84 into master

2024-02-13 16:26:31 +02:00

Manos Pitsidianakis deleted branch bunch-of-fixes-no-jmap

2024-02-13 16:26:31 +02:00

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: meli/meli#354