Set lowest priority to shortcut command UIEvents #348

Manos Pitsidianakis · 2024-01-21T12:52:21+02:00

2024-01-21 12:52:21 +02:00

Commit (a37d5fc1 conf/shortcuts: implement
a key to command mapping) introduced shortcuts that expand to user
defined commands. To allow already existing shortcuts to take
precedence, the check for the user-defined shortcuts should be the last
one in the evaluation order.

Example problem scenario:

Press new_mail shortcut (e.g. m)
Code in listing.rs searches if it matches any of the commands, and
regardless if it matches or not, stops the evaluation and returns.
New mail composer never shows up.

Signed-off-by: Manos Pitsidianakis manos@pitsidianak.is

Commit (a37d5fc1 conf/shortcuts: implement a key to command mapping) introduced shortcuts that expand to user defined commands. To allow already existing shortcuts to take precedence, the check for the user-defined shortcuts should be the last one in the evaluation order. Example problem scenario: - Press new_mail shortcut (e.g. `m`) - Code in listing.rs searches if it matches any of the commands, and regardless if it matches or not, stops the evaluation and returns. - New mail composer never shows up. Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>

Manos Pitsidianakis added 1 commit 2024-01-21 12:52:23 +02:00

Run cargo lints / Lint on ${{ matrix.build }} (linux-amd64, ubuntu-latest, stable, x86_64-unknown-linux-gnu) (pull_request) Successful in 12m2s Details

Run Tests / Test on ${{ matrix.build }} (linux-amd64, ubuntu-latest, stable, x86_64-unknown-linux-gnu) (pull_request) Successful in 19m14s Details

1eca34b398

Set lowest priority to shortcut command UIEvents

Commit (a37d5fc1 conf/shortcuts: implement
a key to command mapping) introduced shortcuts that expand to user
defined commands. To allow already existing shortcuts to take
precedence, the check for the user-defined shortcuts should be the last
one in the evaluation order.

Example problem scenario:
- Press new_mail shortcut (e.g. `m`)
- Code in listing.rs searches if it matches any of the commands, and
  regardless if it matches or not, stops the evaluation and returns.
- New mail composer never shows up.

Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>

Manos Pitsidianakis merged commit 1eca34b398 into master

2024-01-21 15:41:56 +02:00

Manos Pitsidianakis deleted branch cmd-shortcut-fallthrough-order

2024-01-21 15:41:57 +02:00

Sign in to join this conversation.

No reviewers