listing: fix select modifier regression #343

Manos Pitsidianakis · 2024-01-08T12:37:47+02:00

2024-01-08 12:37:47 +02:00

Commit 61a0c3c27f ("listing: do not clear
selection after action") broke select/jump modifiers (e.g. prefixing a
jump with a number).

Requirements

Before submitting your PR, please make sure you have addressed the following requirements:

All commits in this PR are signed (with git commit -s), and the commit has a message describing the motivation behind the change, if appropriate.
All added/changed public-facing functionality, especially configuration options, are documented in the manual pages.
Any newly added unsafe code is properly documented.
Each commit has been formatted with rustfmt. Run make fmt in the project root.
Each commit has been linted with clippy. Run make lint in the project root.
Each commit does not break any test. Run make test in the project root. If you have cargo-nextest installed, you can run cargo nextest run --all --no-fail-fast --all-features --future-incompat-report instead.

Commit 61a0c3c27f7c3691fb8f4503664f80667b0077e2 ("listing: do not clear selection after action") broke select/jump modifiers (e.g. prefixing a jump with a number).  ### Requirements Before submitting your PR, please make sure you have addressed the following requirements: * [x] All commits in this PR are signed (with `git commit -s`), and the commit has a message describing the motivation behind the change, if appropriate. * [x] All added/changed public-facing functionality, especially configuration options, are documented in the manual pages. * [x] Any newly added `unsafe` code is properly documented. * [x] Each commit has been formatted with `rustfmt`. Run `make fmt` in the project root. * [x] Each commit has been linted with `clippy`. Run `make lint` in the project root. * [x] Each commit does not break any test. Run `make test` in the project root. If you have `cargo-nextest` installed, you can run `cargo nextest run --all --no-fail-fast --all-features --future-incompat-report` instead.

Manos Pitsidianakis added 1 commit 2024-01-08 12:37:48 +02:00

Run cargo lints / Lint on ${{ matrix.build }} (linux-amd64, ubuntu-latest, stable, x86_64-unknown-linux-gnu) (pull_request) Successful in 9m51s Details

Run Tests / Test on ${{ matrix.build }} (linux-amd64, ubuntu-latest, stable, x86_64-unknown-linux-gnu) (pull_request) Successful in 15m56s Details

64e60cb0ee

listing: fix select modifier regression

Commit 61a0c3c27f ("listing: do not clear
selection after action") broke select/jump modifiers (e.g. prefixing a
jump with a number).

Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>

Manos Pitsidianakis merged commit 64e60cb0ee into master

2024-01-08 18:28:50 +02:00

Manos Pitsidianakis deleted branch fix-modifier-regression

2024-01-08 18:28:50 +02:00

Sign in to join this conversation.

No reviewers