melib/email/parser: ack \ as an atom #333

Manos Pitsidianakis · 2023-12-26T00:54:55+02:00

Manos Pitsidianakis commented

2023-12-26 00:54:55 +02:00

Summary of the PR

I think this is not spec compliant but the MIME spec (rfc6068 - The
'mailto' URI Scheme) uses it for "valid" addresses.

Cc @duesee

Requirements

Before submitting your PR, please make sure you have addressed the following requirements:

All commits in this PR are signed (with git commit -s), and the commit has a message describing the motivation behind the change, if appropriate.
All added/changed public-facing functionality, especially configuration options, are documented in the manual pages.
Any newly added unsafe code is properly documented.
Each commit has been formatted with rustfmt. Run make fmt in the project root.
Each commit has been linted with clippy. Run make lint in the project root.
Each commit does not break any test. Run make test in the project root. If you have cargo-nextest installed, you can run cargo nextest run --all --no-fail-fast --all-features --future-incompat-report instead.

### Summary of the PR I think this is not spec compliant but the MIME spec (rfc6068 - The 'mailto' URI Scheme) uses it for "valid" addresses. Cc @duesee ### Requirements Before submitting your PR, please make sure you have addressed the following requirements: * [x] All commits in this PR are signed (with `git commit -s`), and the commit has a message describing the motivation behind the change, if appropriate. * [x] All added/changed public-facing functionality, especially configuration options, are documented in the manual pages. * [x] Any newly added `unsafe` code is properly documented. * [x] Each commit has been formatted with `rustfmt`. Run `make fmt` in the project root. * [x] Each commit has been linted with `clippy`. Run `make lint` in the project root. * [x] Each commit does not break any test. Run `make test` in the project root. If you have `cargo-nextest` installed, you can run `cargo nextest run --all --no-fail-fast --all-features --future-incompat-report` instead.

Manos Pitsidianakis added 3 commits 2023-12-26 00:54:55 +02:00

408bcc8d80

melib/error: don't print details if it's an empty string.

Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>

c3ed985b3b

melib/email/parser: add backtrace field to ParsingError

Add backtrace field to ParsingError when the build is for testing or
documentation.

Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>

Run cargo lints / Lint on ${{ matrix.build }} (linux-amd64, ubuntu-latest, stable, x86_64-unknown-linux-gnu) (pull_request) Successful in 11m37s Details

Run Tests / Test on ${{ matrix.build }} (linux-amd64, ubuntu-latest, stable, x86_64-unknown-linux-gnu) (pull_request) Successful in 19m20s Details

8b619ac663

melib/email/parser: ack \ as an atom

I think this is not spec compliant but the MIME spec (rfc6068 - The
'mailto' URI Scheme) uses it for "valid" addresses.

Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>

Manos Pitsidianakis force-pushed ack-slash-for-mailto-rfc from 8b619ac663 to 933bf157ae

2023-12-29 20:02:14 +02:00

Compare

Manos Pitsidianakis merged commit 933bf157ae into master

2023-12-29 20:32:19 +02:00

Manos Pitsidianakis deleted branch ack-slash-for-mailto-rfc

2023-12-29 20:32:19 +02:00

Sign in to join this conversation.

No reviewers