Header code refactors #286

Manos Pitsidianakis · 2023-08-24T11:38:52+03:00

Manos Pitsidianakis commented

2023-08-24 11:38:52 +03:00

If your PR is ready to merge/review, remove the WIP: prefix from the title.

Summary of the PR

Requirements

Before submitting your PR, please make sure you have addressed the following requirements:

All commits in this PR are signed (with git commit -s), and the commit has a message describing the motivation behind the change, if appropriate.
All added/changed public-facing functionality has entries in the "Upcoming Release" section of CHANGELOG.md (if no such section exists, please create one).
All added/changed public-facing functionality, especially configuration options, must be documented in the manual pages.
Any newly added unsafe code is properly documented.
Each commit has been formatted with rustfmt. Run make fmt in the project root.
Each commit has been linted with clippy. Run make lint in the project root.
Each commit does not break any test. Run make test in the project root. If you have cargo-nextest installed, you can run cargo nextest run --all --no-fail-fast --all-features --future-incompat-report instead.

**If your PR is ready to merge/review, remove the `WIP: ` prefix from the title.** ### Summary of the PR ### Requirements Before submitting your PR, please make sure you have addressed the following requirements: * [x] All commits in this PR are signed (with `git commit -s`), and the commit has a message describing the motivation behind the change, if appropriate. * [ ] All added/changed public-facing functionality has entries in the "Upcoming Release" section of CHANGELOG.md (if no such section exists, please create one). * [x] All added/changed public-facing functionality, especially configuration options, must be documented in the manual pages. * [x] Any newly added `unsafe` code is properly documented. * [x] Each commit has been formatted with `rustfmt`. Run `make fmt` in the project root. * [x] Each commit has been linted with `clippy`. Run `make lint` in the project root. * [x] Each commit does not break any test. Run `make test` in the project root. If you have `cargo-nextest` installed, you can run `cargo nextest run --all --no-fail-fast --all-features --future-incompat-report` instead.

Manos Pitsidianakis added 3 commits 2023-08-24 11:38:52 +03:00

66c21ab173

melib/email: move StandardHeader to its own module

Extract StandardHeader code to its own module to reduce name.rs
line-count size.

Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>

946309c6f3

melib: do some small parser refactoring

- Use HeaderName in parsers instead of raw byte strings.
- Use byte literal constants where appropriate instead of repeating
  &b"___"[..]

Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>

Tests / Test on ${{ matrix.build }} (linux-amd64, ubuntu-latest, stable, x86_64-unknown-linux-gnu) (pull_request) Successful in 7m58s Details

f162239fcc

.gitea/workflows: change `on:` conditions for test.yaml

Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>

Manos Pitsidianakis added 2 commits 2023-08-25 08:25:28 +03:00

974b3a5305

Update bitflags, rusqlite dependencies

Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>

Tests / Test on ${{ matrix.build }} (linux-amd64, ubuntu-latest, stable, x86_64-unknown-linux-gnu) (pull_request) Failing after 14m14s Details

Tests / Test on ${{ matrix.build }} (linux-amd64, ubuntu-latest, stable, x86_64-unknown-linux-gnu) (push) Failing after 7m40s Details

4d22b669bf

Cargo.lock: update dependencies

Signed-off-by: Manos Pitsidianakis <manos@pitsidianak.is>

Manos Pitsidianakis changed title from ~~WIP: header refactors~~ to Header code refactors

2023-08-25 08:26:00 +03:00

Manos Pitsidianakis merged commit 4d22b669bf into master

2023-08-25 08:27:21 +03:00

Manos Pitsidianakis deleted branch fix/header-refactors

2023-08-25 08:27:21 +03:00

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: meli/meli#286