melib/jmap: respect max_objects_in_get when fetching email #193

Manos Pitsidianakis · 2022-10-15T18:12:34+03:00

Manos Pitsidianakis commented

2022-10-15 18:12:34 +03:00

There is no content yet.

Manos Pitsidianakis added the

JMAP

label 2022-10-15 18:12:34 +03:00

Manos Pitsidianakis referenced this pull request

2022-10-15 18:13:18 +03:00

JMAP incompatible with Stalwart server #192

rudihorn commented

2022-10-21 18:42:39 +03:00

Thank you very much for the work on this so far @epilys!

Unfortunately it seems like this PR still produces an error respons from the jmap server when opening large mailboxes:

Reply from server: ["error",{"type":"invalidResultReference","description":"Failed to evaluate #ids result reference."},"m4"]

I think it still works fine on smaller mailboxes, but can try debugging a little more.

Thank you very much for the work on this so far @epilys! Unfortunately it seems like this PR still produces an error respons from the jmap server when opening large mailboxes: ``` Reply from server: ["error",{"type":"invalidResultReference","description":"Failed to evaluate #ids result reference."},"m4"] ``` I think it still works fine on smaller mailboxes, but can try debugging a little more.

Manos Pitsidianakis commented

2022-10-21 22:02:05 +03:00

Poster

Thanks a lot for the test @rudihorn . I am busy with work these past few weeks and when I had the time to work on this, I didn't make progress on a way to upload lots of mail into a local stalwart server. I had a fastmail dev account that someone donated but it has since expired and I can't test that. So this is the blocking issue with progress on proper functionality; I suspect when a dev env is available it will be fast to fix it.

rudihorn commented

2022-10-21 23:20:55 +03:00

So doing some more debugging, the requests contain the following email methods:

["Email/query",{"accountId":"c","calculateTotal":false,"collapseThreads":false,"filter":{"inMailbox":"a"},"position":0,"sort":null},"5"],["Email/get",{"#ids":{"name":"Email/query","path":"/ids","resultOf":"5"},"accountId":"c","fetchAllBodyValues":false,"fetchHTMLBodyValues":false,"fetchTextBodyValues":false,"properties":["threadId"]},"6"],...

Method 5 succeeds and returns 5000 (max is 500) entries and then method 6 fails with ["error",{"type":"requestTooLarge","description":"The number of ids requested by the client exceeds the maximum number the server is willing to process in a single method call."},"6"] and all remaining method calls also fail if this helps.

So doing some more debugging, the requests contain the following email methods: ``` ["Email/query",{"accountId":"c","calculateTotal":false,"collapseThreads":false,"filter":{"inMailbox":"a"},"position":0,"sort":null},"5"],["Email/get",{"#ids":{"name":"Email/query","path":"/ids","resultOf":"5"},"accountId":"c","fetchAllBodyValues":false,"fetchHTMLBodyValues":false,"fetchTextBodyValues":false,"properties":["threadId"]},"6"],... ``` Method 5 succeeds and returns 5000 (max is 500) entries and then method 6 fails with `["error",{"type":"requestTooLarge","description":"The number of ids requested by the client exceeds the maximum number the server is willing to process in a single method call."},"6"]` and all remaining method calls also fail if this helps.

Manos Pitsidianakis force-pushed jmap-batch-fetch from b6bcf45fb9 to e64f2077a8

2022-10-24 03:42:48 +03:00

Compare

Manos Pitsidianakis commented

2023-07-18 16:17:26 +03:00

Poster

@rudihorn fixed :)

Manos Pitsidianakis closed this pull request

2023-07-18 16:17:26 +03:00

Manos Pitsidianakis deleted branch jmap-batch-fetch

2023-07-18 16:17:32 +03:00