Feature request: collapsible folders with total counter #163

New Issue

oblitum · 2022-01-30T14:10:20+02:00

oblitum commented

2022-01-30 14:10:20 +02:00

I have a mail folder structure that's "Tagged/some-tag" and I have lots of tags, so this "Tagged" folder contains lots of "tag" folders. It would be nice to be able to have it collapsed, not always expanded. Is it possible to close/open folders and set a default state? It would be useful for top folders to have a counter which is a sum of the counters of the child ones.

Manos Pitsidianakis commented

2022-03-20 17:54:03 +02:00

That would be very useful! It'd require some custom logic for the sidebar widget, but it's doable.

Manos Pitsidianakis added the

enhancement

label 2022-03-20 17:54:13 +02:00

Manos Pitsidianakis commented

2022-08-15 16:34:46 +03:00

Buggy implementation here:

https://git.meli.delivery/meli/meli/src/branch/collapse-mailbox-menu

Buggy implementation here: https://git.meli.delivery/meli/meli/src/branch/collapse-mailbox-menu

Manos Pitsidianakis commented

2022-08-15 23:26:04 +03:00

I have this so far, no collapse indicator like it's usually done in accordeon menus yet.

Other stuff that's missing:

The menu re-rendering after collapsing has some garbage cells that need to be cleared
There's no configuration for setting mailboxes collapsed on startup
Refreshing the menu loses previous collapse settings

These are simple to implement/fix, and when they are the feature will be merged to master.

I have this so far, no collapse indicator like it's usually done in accordeon menus yet. Other stuff that's missing: - The menu re-rendering after collapsing has some garbage cells that need to be cleared - There's no configuration for setting mailboxes collapsed on startup - Refreshing the menu loses previous collapse settings These are simple to implement/fix, and when they are the feature will be merged to master.

Screenshot 2022-08-15 at 11.21.39 PM.png

20 KiB

Screenshot 2022-08-15 at 11.22.03 PM.png

48 KiB

Screenshot 2022-08-15 at 11.21.39 PM.png

Screenshot 2022-08-15 at 11.22.03 PM.png

oblitum commented

2022-08-16 05:55:44 +03:00

Poster

This is cool! I have noticed the new branch on my last pull. I'm eager for the merge :)

Meli is still the best terminal email option IMO, but oh boy, the inconsistency with the counters hits me hard everyday. I tried to dig the codebase a bit on that, but I need some time getting familiar with it to start thinking how this synchronization issues comes up.

This is cool! I have noticed the new branch on my last pull. I'm eager for the merge :) Meli is still the best terminal email option IMO, but oh boy, the inconsistency with the counters hits me hard everyday. I tried to dig the codebase a bit on that, but I need some time getting familiar with it to start thinking how this synchronization issues comes up.

Manos Pitsidianakis commented

2022-08-16 11:23:59 +03:00

The counter thing is going to get a complete overhaul when I'm done with these smaller features/bug fixes. It annoys me as well!

Manos Pitsidianakis referenced this issue from a commit

2022-08-18 18:06:21 +03:00

Add collapse option for mailboxes in sidebar menu

Manos Pitsidianakis commented

2022-08-18 18:14:20 +03:00

Merged in b716e4383e, let me know if anything is misbehaving by reopening this issue or posting a new one, either way is fine.

Merged in b716e4383e, let me know if anything is misbehaving by reopening this issue or posting a new one, either way is fine.

Manos Pitsidianakis closed this issue

2022-08-18 18:14:20 +03:00

Manos Pitsidianakis commented

2022-08-18 18:15:29 +03:00

Documentation:

b716e4383e/docs/meli.conf.5

Ctrl+f "collapse"

Documentation: https://git.meli.delivery/meli/meli/src/commit/b716e4383ea3163cabe760cd5512b7d70b218915/docs/meli.conf.5 Ctrl+f "collapse"

oblitum commented

2022-08-22 14:39:55 +03:00

Poster

Nice. I just built it and tried, it came collapsed, but the "Ctrl+f" hotkey isn't doing anything by default. I have no idea how to expand.

I'd like to inform that your system isn't deliverying notification emails on issues I'm subscribed.

Nice. I just built it and tried, it came collapsed, but the "Ctrl+f" hotkey isn't doing anything by default. I have no idea how to expand. I'd like to inform that your system isn't deliverying notification emails on issues I'm subscribed.

oblitum commented

2022-08-22 14:42:18 +03:00

Poster

"toggle_mailbox_collapse" on "meli.conf" states "Space" as default binding, but this also isn't doing anything, nor "Enter" for opening it.

Manos Pitsidianakis commented

2022-08-22 19:31:03 +03:00

Nice. I just built it and tried, it came collapsed, but the "Ctrl+f" hotkey isn't doing anything by default. I have no idea how to expand.

Oh sorry, by ctrl+F I mean look up the string "collapse" in the manpage document.

"toggle_mailbox_collapse" on "meli.conf" states "Space" as default binding, but this also isn't doing anything, nor "Enter" for opening it.

You have to be focused on the menu first (press left?) It's kinda non-intuitive. I'm open to actually good alternatives for interacting with the sidebar: How do you switch focus seamlessly from the mailbox list to the sidebar?

I'd like to inform that your system isn't deliverying notification emails on issues I'm subscribed.

Thanks, will check it out. As stated elsewhere I moved servers/installations recently.

> Nice. I just built it and tried, it came collapsed, but the "Ctrl+f" hotkey isn't doing anything by default. I have no idea how to expand. Oh sorry, by ctrl+F I mean look up the string "collapse" in the manpage document. > "toggle_mailbox_collapse" on "meli.conf" states "Space" as default binding, but this also isn't doing anything, nor "Enter" for opening it. You have to be focused on the menu first (press left?) It's kinda non-intuitive. I'm open to actually good alternatives for interacting with the sidebar: How do you switch focus seamlessly from the mailbox list to the sidebar? > I'd like to inform that your system isn't deliverying notification emails on issues I'm subscribed. Thanks, will check it out. As stated elsewhere I moved servers/installations recently.

Manos Pitsidianakis commented

2022-08-22 19:39:18 +03:00

I'd like to inform that your system isn't deliverying notification emails on issues I'm subscribed.

I just successfully sent my self a test email, I hope it's fixed now.

> I'd like to inform that your system isn't deliverying notification emails on issues I'm subscribed. I just successfully sent my self a test email, I hope it's fixed now.

oblitum commented

2022-08-28 00:51:09 +03:00

Poster

I'd like to inform that your system isn't deliverying notification emails on issues I'm subscribed.

I just successfully sent my self a test email, I hope it's fixed now.

Seems OK now, thx.

> > I'd like to inform that your system isn't deliverying notification emails on issues I'm subscribed. > > I just successfully sent my self a test email, I hope it's fixed now. Seems OK now, thx.

oblitum commented

2022-08-28 00:53:07 +03:00

Poster

You have to be focused on the menu first (press left?) It's kinda non-intuitive. I'm open to actually good alternatives for interacting with the sidebar: How do you switch focus seamlessly from the mailbox list to the sidebar?

Oh, I didn't realize I could do that, it's fine then, it's working.

> You have to be focused on the menu first (press left?) It's kinda non-intuitive. I'm open to actually good alternatives for interacting with the sidebar: How do you switch focus seamlessly from the mailbox list to the sidebar? Oh, I didn't realize I could do that, it's fine then, it's working.

Manos Pitsidianakis commented

2022-08-28 12:02:28 +03:00

@oblitum I'm planning on adding a help/documentation feature like vim, so that you can bring it up at any view and see what you can do with it. Kinda like the current shortcuts view ? but with text.

@oblitum I'm planning on adding a help/documentation feature like `vim`, so that you can bring it up at any view and see what you can do with it. Kinda like the current shortcuts view `?` but with text.

Manos Pitsidianakis commented

2022-08-28 12:03:29 +03:00

It's all in the configuration manual page, but it has become quite large so one cannot be expected to sit and read all of it to figure out how to do simple stuff.

👍 1

Sign in to join this conversation.