Configurable subject response prefix #175

New Issue

oblitum · 2022-08-31T18:36:24+03:00

oblitum commented

2022-08-31 18:36:24 +03:00

I'd like to request a feature, I think very small, but that annoys me in almost all e-mail clients I've used to this day. I'd like to request for meli to have a configuration option that accepts a list of strings to be used for identifing email response prefixes. Currently when responding an email, meli prefixes the subject with "Re: ", if it's not already in the subject. The problem is, when communicating with diverse people, I often hit someone whose email client picks "RE: " for that, or even "Res: ", etc. What happens then, is that each client can't understand each other, and every subsequential email gets pilled with subject prefixes "Re: RE: Res: Re: Res: Subject", it's really annoying, I often try to evade that by manually editing the subject, but I often forget and notice the problem when it's already in my Sent folder.

Manos Pitsidianakis referenced this issue from a commit

2022-08-31 22:35:48 +03:00

compose: implement configurable subject prefix stripping when replying

Manos Pitsidianakis commented

2022-08-31 22:36:33 +03:00

Is this the solution you were thinking about?

d5594560bf

Is this the solution you were thinking about? https://git.meli.delivery/meli/meli/commit/d5594560bff45562f6c0c771dd8db8854a9354c8

oblitum commented

2022-09-01 00:36:40 +03:00

Poster

Hi @epilys, that seems to be well done and should work out of the box is most cases :)

I'd like to just comment one specific person I interact with over email that has a particular interesting response prefix. Every single prefix of theirs comes with a counter, say, "RE[1]: ", "RE[2]: ", etc. I'm not sure how that should be handled, if at all.

Hi @epilys, that seems to be well done and should work out of the box is most cases :) I'd like to just comment one specific person I interact with over email that has a particular interesting response prefix. Every single prefix of theirs comes with a counter, say, "RE[1]: ", "RE[2]: ", etc. I'm not sure how that should be handled, if at all.

oblitum closed this issue

2022-09-01 00:36:44 +03:00

oblitum commented

2022-09-01 00:45:05 +03:00

Poster

Oh, I think you need to proof read that string list, there's "RE:" twice, and no "Res:", only "RES: ". Seems weird.

oblitum reopened this issue

2022-09-01 00:48:29 +03:00

Manos Pitsidianakis commented

2022-09-01 11:20:03 +03:00

Thanks, I'll fix that! (perils of not having compile-time hash sets)

"RE[1]: ", "RE[2]: ",

Ha! Maybe we could cook something up with the regexp pcre2 feature... Though no guarantee the stripping would happen sequentially 😄

Thanks, I'll fix that! (perils of not having compile-time hash sets) > "RE[1]: ", "RE[2]: ", Ha! Maybe we could cook something up with the regexp `pcre2` feature... Though no guarantee the stripping would happen sequentially 😄

Manos Pitsidianakis referenced this issue from a commit

2022-09-01 22:32:47 +03:00

compose: implement configurable subject prefix stripping when replying

Manos Pitsidianakis commented

2022-09-01 22:33:33 +03:00

Fixed: https://git.meli.delivery/meli/meli/commits/branch/reply-prefix

Manos Pitsidianakis commented

2022-09-01 22:34:14 +03:00

In case you want to review the diffs, I will wait a day or two before merging it into master.

oblitum commented

2022-09-01 23:14:05 +03:00

Poster

It seems nice, waiting for the merge to get my new build :)

Manos Pitsidianakis commented

2022-09-02 01:27:56 +03:00

Merged!

Manos Pitsidianakis closed this issue

2022-09-02 01:27:57 +03:00

oblitum commented

2022-09-02 05:43:54 +03:00

Poster

Thanks!

oblitum commented

2022-09-03 21:51:35 +03:00

Poster

I just realized that an original subject like "RES: something" gets mutated to "Re: something". It's nice to have Re duplication avoided, but not sure about that mutation, it'll either get flipping back and forth, or the other person's client will stack it on further responses ("RES: something" -> "Re: something" -> "RES: Re: something").