Notmuch backend never updates the visible tags #166

New Issue

refi64 · 2022-02-08T01:57:33+02:00

refi64 commented

2022-02-08 01:57:33 +02:00

If I modify the tags on a message, so that it would move between virtual mailboxes, triggering a refresh will not actually move the message, and the old tags are still visible. In addition, if, in my refresh command, I download new mail and change the tags, the old tags are visible in the UI (but the mail is in the correct virtual folder regardless).

If I modify the tags on a message, so that it would move between virtual mailboxes, triggering a refresh will not actually move the message, and the old tags are still visible. In addition, if, in my refresh command, I download new mail *and* change the tags, the old tags are visible in the UI (but the mail is in the correct virtual folder regardless).

Manos Pitsidianakis commented

2022-02-19 19:04:56 +02:00

Ok, it seems the problem is just that the notmuch backend never informs the frontend, that is it never issues any RefreshEvent messages.

The set_flags() function here e9aaa7b067/melib/src/backends/notmuch.rs (L688) is the place where this should happen.

go through the virtual mailboxes where the message belongs, send a remove event for those virtual mailboxes where the message is not visible anymore
also send an add event for any new ones where it's visible now
also send a NewFlags event for the message.

Ok, it seems the problem is just that the `notmuch` backend never informs the frontend, that is it never issues any [`RefreshEvent`](https://git.meli.delivery/meli/meli/src/commit/e9aaa7b067903040acd7f3d7c685de94b3b98450/melib/src/backends.rs#L264) messages. The `set_flags()` function here https://git.meli.delivery/meli/meli/src/commit/e9aaa7b067903040acd7f3d7c685de94b3b98450/melib/src/backends/notmuch.rs#L688 is the place where this should happen. - go through the virtual mailboxes where the message belongs, send a remove event for those virtual mailboxes where the message is not visible anymore - also send an add event for any new ones where it's visible now - also send a `NewFlags` event for the message.

Manos Pitsidianakis added the

bug

notmuch

labels 2022-02-19 19:05:04 +02:00

Manos Pitsidianakis referenced this issue from a commit

2022-09-19 15:10:17 +03:00

melib/notmuch: issue proper Refresh events in set_flags()

Manos Pitsidianakis referenced this issue from a commit

2022-09-19 15:19:24 +03:00

melib/notmuch: issue proper Refresh events in set_flags()

Manos Pitsidianakis referenced a pull request that will close this issue

2022-09-19 15:19:57 +03:00