Melib: JMap is_online doesn't await connection #159
Labels
No Label
IMAP
JMAP
Maildir
Retired
User Experience
User Interface
bsd
bug
contacts
currently worked on
documentation
duplicate
easy
enhancement
help wanted
invalid
linux-gnu
macos
mbox
notmuch
question
security
wishlist
wontfix
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: meli/meli#159
Loading…
Reference in New Issue
There is no content yet.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?
If you construct a JmapType and then immediately await
is_online
like so:It will always fail. Conversely the same order of operations works for ImapType. This issues arises because the implementation
is_online
does not await the connection when it probably should:https://git.meli.delivery/meli/meli/src/branch/master/melib/src/backends/jmap.rs#L302
Hm basically you're suggesting we comment out the:
part, like it's done in
ImapType
? That seems sensible. Thanks for spotting it :)