Stop hardcoding certain component colors #157
Labels
No Label
IMAP
JMAP
Maildir
Retired
User Experience
User Interface
bsd
bug
contacts
currently worked on
documentation
duplicate
easy
enhancement
help wanted
invalid
linux-gnu
macos
mbox
notmuch
question
security
wishlist
wontfix
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: meli/meli#157
Loading…
Reference in New Issue
There is no content yet.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?
The top right heading ("[neomutt-devel...") here has a hard-coded dark blue color: https://meli.delivery/images/screenshots/conversations-view-open-thread.webp
Some of the threading UI and contacts UI too. Searching for "Color::Byte" finds quite a few references.
Hello! Thanks for the issue. Indeed these
Color::Byte
references were before themes were introduced in the code base. Their presence is a bug and they should all be replaced by theme values.There are some hardcoded colors left in
src/components/utilities/widgets.rs:1023
but I added aFIXME
comment and I guess they are low priority. Will fix though.