Stop hardcoding certain component colors #124

Closed
opened 1 year ago by archseer · 2 comments
archseer commented 1 year ago

The top right heading ("[neomutt-devel...") here has a hard-coded dark blue color: https://meli.delivery/images/screenshots/conversations-view-open-thread.webp

Some of the threading UI and contacts UI too. Searching for "Color::Byte" finds quite a few references.

The top right heading ("[neomutt-devel...") here has a hard-coded dark blue color: https://meli.delivery/images/screenshots/conversations-view-open-thread.webp Some of the threading UI and contacts UI too. Searching for "Color::Byte" finds quite a few references.
Owner

Hello! Thanks for the issue. Indeed these Color::Byte references were before themes were introduced in the code base. Their presence is a bug and they should all be replaced by theme values.

Hello! Thanks for the issue. Indeed these `Color::Byte` references were before themes were introduced in the code base. Their presence is a bug and they should all be replaced by theme values.
epilys added the
bug
easy
labels 1 year ago
epilys closed this issue 11 months ago
Owner

There are some hardcoded colors left in src/components/utilities/widgets.rs:1023 but I added a FIXME comment and I guess they are low priority. Will fix though.

There are some hardcoded colors left in [`src/components/utilities/widgets.rs:1023`](https://git.meli.delivery/meli/meli/src/commit/2eb22a290abb3f37bc77c3bc2771edfb60a1c314/src/components/utilities/widgets.rs#L1023) but I added a `FIXME` comment and I guess they are low priority. Will fix though.
Sign in to join this conversation.
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Loading…
There is no content yet.