Invalid display of unicode pager search results #120

New Issue

Manos Pitsidianakis · 2020-12-01T15:20:24+02:00

2020-12-01 15:20:24 +02:00

Search in melib/src/text_processing/search.rs:58 returns position of starting grapheme of match in string instead of starting column of match. So, if string contains graphemes of more than bytes the match position will be displayed wrong.

Drawing match positions in pager is done here src/components/utilities/pager.rs:343

Search in [`melib/src/text_processing/search.rs:58`](https://git.meli.delivery/meli/meli/src/commit/7db32ff1b382bcdd562909855893dd4252d2e41e/melib/src/text_processing/search.rs#L58) returns position of starting grapheme of match in string instead of starting column of match. So, if string contains graphemes of more than bytes the match position will be displayed wrong. Drawing match positions in pager [is done here `src/components/utilities/pager.rs:343`](https://git.meli.delivery/meli/meli/src/commit/7db32ff1b382bcdd562909855893dd4252d2e41e/src/components/utilities/pager.rs#L343)

Manos Pitsidianakis added the

bug

easy

labels 2020-12-01 15:20:24 +02:00

Manos Pitsidianakis added the

Retired

label 2023-09-07 15:55:30 +03:00

Manos Pitsidianakis closed this issue

2023-09-07 15:55:49 +03:00

Sign in to join this conversation.