panic when deleting email from other client #110

New Issue

oblitum · 2020-10-10T23:55:38+03:00

oblitum commented

2020-10-10 23:55:38 +03:00

I was with meli open and, as I have no idea how to delete emails for its UI (I just get "unimplemented"), I deleted one email from my cellphone mail client. This was the sole email being listed in open folder in meli, as soon as I deleted it in my cellphone, meli panicked with:

thread 'meli-executor-6' panicked at 'removal index (is 1) should be < len (is 1)', src/liballoc/vec.rs:1062:13

I was with meli open and, as I have no idea how to delete emails for its UI (I just get "unimplemented"), I deleted one email from my cellphone mail client. This was the sole email being listed in open folder in meli, as soon as I deleted it in my cellphone, meli panicked with: ``` thread 'meli-executor-6' panicked at 'removal index (is 1) should be < len (is 1)', src/liballoc/vec.rs:1062:13 ```

Manos Pitsidianakis added the

bug

label 2020-10-11 01:12:24 +03:00

Manos Pitsidianakis commented

2020-10-11 16:45:03 +03:00

I've located the cause here melib/src/backends/imap/untagged.rs:98

IMAP server sent EXPUNGE 1, and here:

self
                    .uid_store
                    .msn_index
                    .lock()
                    .unwrap()
                    .entry(mailbox_hash)
                    .or_default()
                    .remove(n.try_into().unwrap());

The vector is 0-indexed but message sequence numbers in IMAP start from 1. The fix is to subtract 1 from the index.

I've located the cause here [`melib/src/backends/imap/untagged.rs:98`](https://git.meli.delivery/meli/meli/src/branch/master/melib/src/backends/imap/untagged.rs#L98) IMAP server sent `EXPUNGE 1`, and here: ``` self .uid_store .msn_index .lock() .unwrap() .entry(mailbox_hash) .or_default() .remove(n.try_into().unwrap()); ``` The vector is 0-indexed but message sequence numbers in IMAP start from 1. The fix is to subtract 1 from the index.

Manos Pitsidianakis referenced this issue from a commit

2020-10-11 16:55:08 +03:00

imap: fix out of bounds panic on receive EXPUNGE Closes #82

Manos Pitsidianakis closed this issue

2020-10-11 16:55:08 +03:00

Sign in to join this conversation.