fixup some TODO and FIXMEs

jmap
Manos Pitsidianakis 2019-11-22 13:59:00 +02:00
parent 501f1a0e1e
commit 424b244bb7
Signed by: Manos Pitsidianakis
GPG Key ID: 73627C2F690DF710
4 changed files with 34 additions and 31 deletions

View File

@ -477,7 +477,6 @@ fn examine_updates(
*v = ok.uidvalidity; *v = ok.uidvalidity;
} }
} else { } else {
// FIXME: Handle this case in ui/src/conf/accounts.rs
sender.send(RefreshEvent { sender.send(RefreshEvent {
hash: folder_hash, hash: folder_hash,
kind: RefreshEventKind::Rescan, kind: RefreshEventKind::Rescan,

View File

@ -250,7 +250,6 @@ impl ThreadListing {
if !(self.cursor_pos.0 == self.new_cursor_pos.0 if !(self.cursor_pos.0 == self.new_cursor_pos.0
&& self.cursor_pos.1 == self.new_cursor_pos.1) && self.cursor_pos.1 == self.new_cursor_pos.1)
{ {
//TODO: store cursor_pos in each folder
self.cursor_pos.2 = 0; self.cursor_pos.2 = 0;
self.new_cursor_pos.2 = 0; self.new_cursor_pos.2 = 0;
} }
@ -451,15 +450,14 @@ impl ThreadListing {
s.push('>'); s.push('>');
} }
s.push_str(if envelope.has_attachments() {
"📎"
} else {
""
});
if show_subject { if show_subject {
s.push_str(&format!("{:.85}", envelope.subject())); s.push_str(&format!("{:.85}", envelope.subject()));
} }
/* TODO Very slow since we have to build all attachments
let attach_count = envelope.body(op).count_attachments();
if attach_count > 1 {
s.push_str(&format!(" {}∞ ", attach_count - 1));
}
*/
s s
} }
fn format_date(envelope: &Envelope) -> String { fn format_date(envelope: &Envelope) -> String {

View File

@ -166,30 +166,37 @@ pub struct Account {
impl Drop for Account { impl Drop for Account {
fn drop(&mut self) { fn drop(&mut self) {
//TODO: Avoid panics if let Ok(data_dir) = xdg::BaseDirectories::with_profile("meli", &self.name) {
let data_dir = xdg::BaseDirectories::with_profile("meli", &self.name).unwrap(); if let Ok(data) = data_dir.place_data_file("addressbook") {
if let Ok(data) = data_dir.place_data_file("addressbook") { /* place result in cache directory */
/* place result in cache directory */ let f = match fs::File::create(data) {
let f = match fs::File::create(data) { Ok(f) => f,
Ok(f) => f, Err(e) => {
Err(e) => { eprintln!("{}", e);
panic!("{}", e); return;
} }
};
let writer = io::BufWriter::new(f);
if let Err(err) = serde_json::to_writer(writer, &self.address_book) {
eprintln!("{}", err);
return;
};
}; };
let writer = io::BufWriter::new(f); if let Ok(data) = data_dir.place_data_file("mailbox") {
serde_json::to_writer(writer, &self.address_book).unwrap(); /* place result in cache directory */
}; let f = match fs::File::create(data) {
if let Ok(data) = data_dir.place_data_file("mailbox") { Ok(f) => f,
/* place result in cache directory */ Err(e) => {
let f = match fs::File::create(data) { eprintln!("{}", e);
Ok(f) => f, return;
Err(e) => { }
panic!("{}", e); };
} let writer = io::BufWriter::new(f);
if let Err(err) = bincode::serialize_into(writer, &self.folders) {
eprintln!("{}", err);
};
}; };
let writer = io::BufWriter::new(f); }
bincode::serialize_into(writer, &self.folders).unwrap();
};
} }
} }

View File

@ -641,7 +641,6 @@ pub enum Attr {
BoldReverseUnderline = 0b111, BoldReverseUnderline = 0b111,
} }
// TODO: word break.
pub fn copy_area_with_break( pub fn copy_area_with_break(
grid_dest: &mut CellBuffer, grid_dest: &mut CellBuffer,
grid_src: &CellBuffer, grid_src: &CellBuffer,