cycomanic
  • Joined on Mar 23, 2020

cycomanic commented on issue meli/meli#21

theming suggestions

Actually, you're right it does not make a difference, because it does not really matter if you put in a color or the "parent" keyword. It would be nice to be able to define custom color names though, that way it's easier to reuse colors, without making mistakes.

2 years ago

cycomanic commented on issue meli/meli#21

theming suggestions

> The problem with this is that there's no distinction for a user-set value vs app-default in themes, so there's no way to know if for example the unseen even background should default to even background unless user has set the unseen even background value. Ok I understand. Maybe the option to avoid the verbosity is to have a keyword parent? And then make a bit more hierachy, i.e. have list.odd.unseen , list.even.unseen, list.even.selected ... if one would then set list.odd.unseen = {fg="parent", bg="white"} it takes the foreground value from the parent, i.e. list.odd? Obviously what you did works as well I'm just thinking about a way to avoid having to repeat a lot of values.

2 years ago

cycomanic opened issue meli/meli#21

theming suggestions

2 years ago

cycomanic commented on issue meli/meli#20

notmuch search over whole database

OK I thought I was doing something wrong. Regarding a search interface, I suggest doing two separate commands (.e.g search and query) for the two use cases.

2 years ago

cycomanic commented on issue meli/meli#19

crash with chinese character emails

Let me know if I can do anything else to debug. If you point me to the right file where I should look I can try to debug further myself.

2 years ago

cycomanic opened issue meli/meli#20

notmuch search over whole database

2 years ago

cycomanic commented on issue meli/meli#19

crash with chinese character emails

That's weird if I subscribe to a different mailbox (i.e. a different tag) and I do a search tag:inbox I do not get all results but just the results that have that tag in the current mailbox. I am using the "/" shortcut and then tag:inbox

2 years ago

cycomanic commented on issue meli/meli#19

crash with chinese character emails

OK here is another one that causes issues for me, but even after removing that message I get a crash.

2 years ago

cycomanic commented on issue meli/meli#19

crash with chinese character emails

It happens when I open meli with "INBOX" = { query="tag:inbox", subscribe=true} However I've just found that I still get the crash even without that file. So I'm not sure if it was actually that mail (I tested with "INBOX" {query="thread:xxxx", subscribe=true} where the xxx corresponded to the thread of the above mail. I will see if I can find another email that is causing issues. Is there a way I can search the whole notmuch database, not just the subscribed mailbox?

2 years ago

cycomanic commented on issue meli/meli#19

crash with chinese character emails

Attached

2 years ago

cycomanic commented on issue meli/meli#19

crash with chinese character emails

OK one more follow up, maybe the bug is related to notmuch. If I forward the email to my fastmail account things work with the jmap backend

2 years ago

cycomanic commented on issue meli/meli#19

crash with chinese character emails

I renamed the bug, because I'm not sure this is actually a notmuch backend bug.

2 years ago

cycomanic commented on issue meli/meli#19

crash with chinese character emails

Some more info. I've narrowed it down to some spam messages with chinese characters. Here is one of the offending messages (from notmuch show): ``` message{ id:8f832ff8-02a3-4b0d-9ced-4c8f9f708559 depth:0 match:1 excluded:0 filename:/home/jschrod/.Mail/Chalmers/INBOX/new/1585554068.M143105071P11995Q27432Rc0c2cca5.linux-rxj5 header{ <hk13642980935@hotmail.com> (Thu. 02:17) (inbox unread) Subject: 大陆出口香港专线,可接化妆品,口罩,洗发水,洗手液等 From: <hk13642980935@hotmail.com> To: jochen.schroeder@chalmers.se Date: Thu, 26 Mar 2020 09:17:12 +0800 header} body{ part{ ID: 1, Content-type: multipart/alternative part{ ID: 2, Content-type: text/plain &nbsp; &nbsp;大陆出口香港专线,可接化妆品,口罩,洗发水,洗手液等 &nbsp;■&nbsp; 大陆上门提货,运输报关一条龙服务 &nbsp;■&nbsp; 香港有卸货平台,可提供装卸货,拼箱,仓储服务 &nbsp;■&nbsp; 九龙/新界/港岛派送公司以及仓库 &nbsp;■ &nbsp;香港机场/仓码头仓入仓服务 &nbsp; 联系我们 联系人:Jack Mobile&nbsp;:+86-13642980935 (微信同号) E-mail :&nbsp;hk13642980935@hotmail.com part} part{ ID: 3, Content-type: text/html Non-text part: text/html part} part} body} message} ```

2 years ago

cycomanic commented on issue meli/meli#19

crash with chinese character emails

Here is the trace when running with debug: ``` ["ThreadId(3)"] src/workers.rs:203_21: Waiting for work ["ThreadId(4)"] src/workers.rs:203_21: ["ThreadId(5)"] src/workers.rs:203_21: Waiting for work Waiting for work ["ThreadId(6)"] src/workers.rs:203_21: Waiting for work ["main"] src/state.rs:346_9: inserting mailbox hashes: ["ThreadId(3)"] src/workers.rs:211_33: Got some work ["ThreadId(7)"] src/workers.rs:287_33: &static_threads[&thread_id] = Worker { name: "Parsing todo", status: "Waiting for subworkers.." } ["main"] src/state.rs:144_21: hash & mailbox: 10602554343703510768 INBOX ["main"] src/state.rs:144_21: hash & mailbox: 13109668137688561691 Sent ["main"] src/state.rs:144_21: hash & mailbox: 3288688478793996316 todo ["main"] src/components/mail/listing.rs:1213_71: self.get_status(context) = "Mailbox: INBOX, Messages: 0, New: 0" ["main"] src/components/mail/listing.rs:1213_71: self.get_status(context) = "Mailbox: INBOX, Messages: 0, New: 0" ["main"] src/conf/accounts.rs:757_42: w.poll() = Ok(AsyncStatus<T>::NoUpdate) ["ThreadId(7)"] src/workers.rs:287_33: &static_threads[&thread_id] = Worker { name: "Parsing INBOX", status: "Waiting for subworkers.." } ["ThreadId(5)"] src/workers.rs:211_33: Got some work ["ThreadId(4)"] src/workers.rs:211_33: Got some work ["ThreadId(7)"] src/workers.rs:287_33: &static_threads[&thread_id] = Worker { name: "Parsing Sent", status: "Waiting for subworkers.." } ["main"] src/bin.rs:414_31: &r = Ok(NewThread(ThreadId(11), "watching notmuch")) ["main"] src/bin.rs:414_31: &r = Ok(Input(Char('j'))) ["main"] src/bin.rs:414_31: &r = Ok(Input(Char('k'))) ["main"] src/bin.rs:414_31: &r = Ok(Input(Char('j'))) ["ThreadId(3)"] src/workers.rs:213_33: finished work ["ThreadId(9)"] src/conf/accounts.rs:398_23: mailbox_handle.poll_block() = Ok(AsyncStatus<T>::Payload(_)) ["ThreadId(9)"] src/conf/accounts.rs:401_25: notifying for 3288688478793996316 ["ThreadId(9)"] src/conf/accounts.rs:398_23: mailbox_handle.poll_block() = Ok(AsyncStatus<T>::Finished) ["ThreadId(9)"] src/conf/accounts.rs:407_25: exiting ["main"] src/bin.rs:414_31: &r = Ok(UIEvent(WorkerProgress(3288688478793996316))) ["main"] src/conf/accounts.rs:757_42: w.poll() = Ok(AsyncStatus<T>::Payload(_)) ["main"] src/conf/accounts.rs:762_25: got payload in status for 3288688478793996316 ["ThreadId(3)"] src/workers.rs:203_21: Waiting for work ["main"] src/conf/accounts.rs:757_42: w.poll() = Ok(AsyncStatus<T>::Finished) ["main"] src/conf/accounts.rs:794_25: got finished in status for 3288688478793996316 ["main"] src/bin.rs:414_31: &r = Ok(UIEvent(WorkerProgress(3288688478793996316))) ["main"] src/bin.rs:414_31: &r = Ok(UIEvent(StartupCheck(3288688478793996316))) ["main"] src/bin.rs:414_31: &r = Ok(UIEvent(MailboxUpdate((0, 3288688478793996316)))) thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: FromUtf8Error { bytes: [74, 111, 99, 104, 101, 110, 32, 83, 99, 104, 114, 246, 101, 100, 101, 114], error: Utf8Error { valid_up_to: 11, error_len: Some(1) } }', src/libcore/result.rs:1165:5 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace. thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "PoisonError { inner: .. }"', src/libcore/result.rs:1165:5 ["main"] src/bin.rs:414_31: &r = Ok(Input(Char('q'))) thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: "PoisonError { inner: .. }"', src/libcore/result.rs:1165:5 ["ThreadId(6)"] src/workers.rs:206_29: ["ThreadId(7)"] src/workers.rs:249_25: received thread_end_rx, quitting received thread_end_rx, quitting ["ThreadId(6)"] src/workers.rs:228_17: Thread 3 did 0 jobs. ["ThreadId(3)"] src/workers.rs:206_29: received thread_end_rx, quitting ["ThreadId(3)"] src/workers.rs:228_17: Thread 0 did 1 jobs. ```

2 years ago

cycomanic opened issue meli/meli#19

notmuch backend crash

2 years ago

cycomanic commented on issue meli/meli#18

jmap date incorrect

Yes that fixed it. I am happy to sponsor a 1 year subscription to fastmail if that would help with meli development. Unfortunately I have not used rust and am too occupied with other things to learn enough to contribute at the moment.

2 years ago

cycomanic opened issue meli/meli#18

jmap date incorrect

2 years ago